-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix argNorm/DeepARG overwriting output #409
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just to check: no other tests need updating?
Thanks @jfy133 @FriederikeHanssen 🚀 And no further tests are needed because there are no ARG hits in the samplesheets of other tests than "preannotated". It's already on the wishlist to update them ;) |
This fixes a bug of argNorm parsing the two DeepARG output files. Now it correctly outputs 2 files instead of overwriting one with the other.
PR checklist
nf-core lint
).nextflow run . -profile test,singularity --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).